[Spice-devel] [spice-xpi PATCH 1/3] logging: add logging of variable setting (#753155)

[Yaniv Kaul]

----- Original Message -----
> ----- Original Message -----
> > Password and TrustStore are not logged.
> > ---
> >  SpiceXPI/src/plugin/plugin.cpp |   20 +++++++++++++++++++-
> >  1 files changed, 19 insertions(+), 1 deletions(-)
> > 
> > diff --git a/SpiceXPI/src/plugin/plugin.cpp
> > b/SpiceXPI/src/plugin/plugin.cpp
> > index 2dada12..0b2ec4e 100644
> > --- a/SpiceXPI/src/plugin/plugin.cpp
> > +++ b/SpiceXPI/src/plugin/plugin.cpp
> > @@ -274,6 +274,7 @@ char *nsPluginInstance::GetHostIP() const
> >  void nsPluginInstance::SetHostIP(const char *aHostIP)
> >  {
> >      m_host_ip = aHostIP;
> > +    DBG(3, "New HostIP " << m_host_ip);
> >  }
> >  
> >  /* attribute string port; */
> > @@ -285,6 +286,7 @@ char *nsPluginInstance::GetPort() const
> >  void nsPluginInstance::SetPort(const char *aPort)
> >  {
> >      m_port = aPort;
> > +    DBG(3, "New Port " << m_port);
> >  }
> >  
> >  /* attribute string SecurePort; */
> > @@ -296,6 +298,7 @@ char *nsPluginInstance::GetSecurePort() const
> >  void nsPluginInstance::SetSecurePort(const char *aSecurePort)
> >  {
> >      m_secure_port = aSecurePort;
> > +    DBG(3, "New Secure Port " << m_secure_port);
> >  }
> >  
> >  /* attribute string Password; */
> > @@ -307,6 +310,7 @@ char *nsPluginInstance::GetPassword() const
> >  void nsPluginInstance::SetPassword(const char *aPassword)
> >  {
> >      m_password = aPassword;
> > +    DBG(3, "New Password");
> 
> Password is rarely a good thing to log, even if it's OTP.
> Y.

Ignore, 
just noticed you are not logging it, just its existence.
Y.

> 
> >  }
> >  
> >  /* attribute string CipherSuite; */
> > @@ -318,6 +322,7 @@ char *nsPluginInstance::GetCipherSuite() const
> >  void nsPluginInstance::SetCipherSuite(const char *aCipherSuite)
> >  {
> >      m_cipher_suite = aCipherSuite;
> > +    DBG(3, "New CipherSuite " << m_cipher_suite);
> >  }
> >  
> >  /* attribute string SSLChannels; */
> > @@ -329,6 +334,7 @@ char *nsPluginInstance::GetSSLChannels() const
> >  void nsPluginInstance::SetSSLChannels(const char *aSSLChannels)
> >  {
> >      m_ssl_channels = aSSLChannels;
> > +    DBG(3, "New SSL channels" << m_ssl_channels);
> >  }
> >  
> >  //* attribute string TrustStore; */
> > @@ -340,6 +346,7 @@ char *nsPluginInstance::GetTrustStore() const
> >  void nsPluginInstance::SetTrustStore(const char *aTrustStore)
> >  {
> >      m_trust_store = aTrustStore;
> > +    DBG(3, "New TrustStore ");
> >  }
> >  
> >  /* attribute string HostSubject; */
> > @@ -351,6 +358,7 @@ char *nsPluginInstance::GetHostSubject() const
> >  void nsPluginInstance::SetHostSubject(const char *aHostSubject)
> >  {
> >      m_host_subject = aHostSubject;
> > +    DBG(3, "New HostSubject " << m_host_subject);
> >  }
> >  
> >  /* attribute boolean fullScreen; */
> > @@ -362,6 +370,7 @@ PRBool nsPluginInstance::GetFullScreen() const
> >  void nsPluginInstance::SetFullScreen(PRBool aFullScreen)
> >  {
> >      m_fullscreen = aFullScreen;
> > +    DBG(3, "New FullScreen request " << m_fullscreen);
> >  }
> >  
> >  /* attribute string Title; */
> > @@ -373,6 +382,7 @@ char *nsPluginInstance::GetTitle() const
> >  void nsPluginInstance::SetTitle(const char *aTitle)
> >  {
> >      m_title = aTitle;
> > +    DBG(3, "New Title " << m_title);
> >  }
> >  
> >  /* attribute string dynamicMenu; */
> > @@ -384,6 +394,7 @@ char *nsPluginInstance::GetDynamicMenu() const
> >  void nsPluginInstance::SetDynamicMenu(const char *aDynamicMenu)
> >  {
> >      m_dynamic_menu = aDynamicMenu;
> > +    DBG(3, "New DynamicMenu " << m_dynamic_menu);
> >  }
> >  
> >  /* attribute string NumberOfMonitors; */
> > @@ -395,6 +406,7 @@ char *nsPluginInstance::GetNumberOfMonitors()
> > const
> >  void nsPluginInstance::SetNumberOfMonitors(const char
> >  *aNumberOfMonitors)
> >  {
> >      m_number_of_monitors = aNumberOfMonitors;
> > +    DBG(3, "New NumberOfMonitors " << m_number_of_monitors);
> >  }
> >  
> >  /* attribute boolean AdminConsole; */
> > @@ -406,6 +418,7 @@ PRBool nsPluginInstance::GetAdminConsole()
> > const
> >  void nsPluginInstance::SetAdminConsole(PRBool aAdminConsole)
> >  {
> >      m_admin_console = aAdminConsole;
> > +    DBG(3, "New AdminConsole " << m_admin_console);
> >  }
> >  
> >  /* attribute string GuestHostName; */
> > @@ -417,6 +430,7 @@ char *nsPluginInstance::GetGuestHostName()
> > const
> >  void nsPluginInstance::SetGuestHostName(const char
> >  *aGuestHostName)
> >  {
> >      m_guest_host_name = aGuestHostName;
> > +    DBG(3, "New GuestHostName " << m_guest_host_name);
> >  }
> >  
> >  /* attribute string HotKey; */
> > @@ -428,6 +442,7 @@ char *nsPluginInstance::GetHotKeys() const
> >  void nsPluginInstance::SetHotKeys(const char *aHotKeys)
> >  {
> >      m_hot_keys = aHotKeys;
> > +    DBG(3, "New HotKeys " << m_hot_keys);
> >  }
> >  
> >  /* attribute boolean NoTaskMgrExecution; */
> > @@ -439,8 +454,10 @@ PRBool
> > nsPluginInstance::GetNoTaskMgrExecution()
> > const
> >  void nsPluginInstance::SetNoTaskMgrExecution(PRBool
> >  aNoTaskMgrExecution)
> >  {
> >      m_no_taskmgr_execution = aNoTaskMgrExecution;
> > +    DBG(3, "New NoTaskMgrExecution " << m_no_taskmgr_execution);
> >  }
> >  
> > +
> >  /* attribute boolean SendCtrlAltdelete; */
> >  PRBool nsPluginInstance::GetSendCtrlAltdelete() const
> >  {
> > @@ -450,6 +467,7 @@ PRBool nsPluginInstance::GetSendCtrlAltdelete()
> > const
> >  void nsPluginInstance::SetSendCtrlAltdelete(PRBool
> >  aSendCtrlAltdelete)
> >  {
> >      m_send_ctrlaltdel = aSendCtrlAltdelete;
> > +    DBG(3, "New SendCtrlAltDelete " << m_send_ctrlaltdel);
> >  }
> >  
> >  /* attribute unsigned short UsbListenPort; */
> > @@ -674,7 +692,7 @@ void nsPluginInstance::SetLanguageStrings(const
> > char *aSection, const char *aLan
> >      {
> >          if (strlen(aSection) > 0 && strlen(aLanguage) > 0)
> >              m_language[aSection] = aLanguage;
> > -
> > +            DBG(3, "New Language: " << aSection << " --> " <<
> > aLanguage);
> >      }
> >  }
> >  
> > --
> > 1.7.1
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> > 
>