[Spice-devel] [PATCH spice-gtk 03/10] usbredir: USB channels can not be read only

[Hans de Goede]

Hi,

On 01/02/2012 02:39 PM, Christophe Fergeau wrote:
> And I think this is the last patch I hadn't looked at (let me know if I
> missed some in this series :)
>
> On Mon, Dec 19, 2011 at 12:24:36PM +0100, Hans de Goede wrote:
>> A usbredir channel must always be bi-directional. spice-server
>> allows only one client to connect even when in multi-client mode. Since
>> usually there are multiple usb channels available, it is allowed for one client
>> to use one channel, while another client uses another usb channel.
>>
>> Signed-off-by: Hans de Goede<hdegoede at redhat.com>
>> ---
>>   gtk/channel-usbredir.c |    3 ---
>>   1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
>> index 06d80d5..6574e32 100644
>> --- a/gtk/channel-usbredir.c
>> +++ b/gtk/channel-usbredir.c
>> @@ -350,9 +350,6 @@ void spice_usbredir_channel_do_write(SpiceUsbredirChannel *channel)
>>   {
>>       SpiceUsbredirChannelPrivate *priv = channel->priv;
>>
>> -    if (spice_channel_get_read_only(SPICE_CHANNEL(channel)))
>> -        return;
>> -
>
> Even with this removed, won't msg_check_read_only from spice-channel.c
> trigger on these messages and spice_channel_write_msg refuse to send the
> message?

Yes, but at least there it will complain :) I'll gladly admit that usbredir
needs more testing / thinking about when used in combination with multe client.

Regards,

Hans