[Spice-devel] "Make path to the USB ACL helper configurable" breaks making helper suid root

[Christophe Fergeau]

Hi,

On Tue, Jan 03, 2012 at 05:13:38PM +0100, Hans de Goede wrote:
> The "Make path to the USB ACL helper configurable" patch breaks the
> usb acl helper being suid root after make install, this happens now
> because you've changed it from being part of bin_PROGRAMS and moved
> it to acl_PROGRAMS, causing install-exec-hook to run *before* the helper
> itself gets installed...

Are you sure about this? I just tested it here, I changed the hook to
-       -chown root $(DESTDIR)$(acldir)/spice-client-glib-usb-acl-helper
-       -chmod u+s  $(DESTDIR)$(acldir)/spice-client-glib-usb-acl-helper
+       ls -l $(DESTDIR)$(acldir)/spice-client-glib-usb-acl-helper
+       chown root $(DESTDIR)$(acldir)/spice-client-glib-usb-acl-helper
+       chmod u+s  $(DESTDIR)$(acldir)/spice-client-glib-usb-acl-helper
and then ran LC_ALL=C make install -j5 &>foo.log
and foo.log has:
ls -l /home/teuf/usr/bin//spice-client-glib-usb-acl-helper
-rwxr-xr-x. 1 teuf teuf 31485 Jan  4 12:57 /home/teuf/usr/bin//spice-client-glib-usb-acl-helper
chown root /home/teuf/usr/bin//spice-client-glib-usb-acl-helper
chown: changing ownership of
`/home/teuf/usr/bin//spice-client-glib-usb-acl-helper': Operation not
permitted

(I made sure to remove /home/teuf/usr/bin//spice-client-glib-usb-acl-helper
first).

Can you provide a make install log showing the issue so that I can look
more into it?

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120104/c7cd7eca/attachment.pgp>