[Spice-devel] [PATCH v2 spice-gtk 1/3] spice-session/spice_uri_parse: fail if a key is seen twice

[Alon Levy]

On Thu, Jan 05, 2012 at 12:49:20PM +0100, Marc-André Lureau wrote:
> On Thu, Jan 5, 2012 at 12:34 PM, Alon Levy <alevy at redhat.com> wrote:
> 
> > On Thu, Jan 05, 2012 at 12:25:12PM +0100, Marc-André Lureau wrote:
> > > On Tue, Jan 3, 2012 at 5:52 PM, Alon Levy <alevy at redhat.com> wrote:
> > >
> > > > +    int punctuation = 0;
> > > >
> > >
> > > what is this for?
> >
> > So we don't accept something like:
> > spice://hostname?tls-port=1234:1233        INVALID
> >
> > so you count the number of "?:&" (punctuation) seen, if you see a ':'
> > and it isn't the first, fail. This also catches double colon:
> > spice://hostname:1234:1235                 INVALID
> >
> >
> Yeah, I figured it was used in second patch, could you move it there?

Sure. Ack with that to both?

> 
> 
> -- 
> Marc-André Lureau