[Spice-devel] [PATCH spice-protocol v2 0/4] Removing sub_list & serial from messages header v2

Alon Levy alevy at redhat.com
Tue Jan 10 04:58:09 PST 2012


On Tue, Jan 10, 2012 at 01:24:35PM +0200, Yonit Halperin wrote:
> Main changes from v1

ACK series (just minor comments on individual patches).

> 
> spice-server:
> - adding spice_msg_list to spice.proto
> - rename usbredir to spicevmc in spice.proto
> - adding comments in tricky places
> - refactor display_begin_send_message
> - Protocol release s/0.10.0/0.10.1
> 
> spice-proto:
> - generating enums.h from spice.proto
> - s/0.10.0/0.10.1
> 
> ============
> Hi,
> 
> This patch series introduces SPICE_COMMON_CAP_MINI_HEADER, in order to spare
> the 12 bytes of sub_list & serial that were sent for all the messages. It replaces
> the previous patch series that removed only the sub_list.
> I implemented the sub_list functionality by using an additional
> marshaller in red_channel, which I named urgent marshaller. This
> marshaller allows marshalling messages that we find out we need to send
> in the middle of marshalling another message (and we need to send them before it).
> In addition, I introduce the msg type SPICE_MSG_LIST, for cases that the "urgent" message
> is composed of several messages, and for future use, in case we wish to aggregate
> several messages together.
> As Alon noticed, the functionally of sending the serial can be replaced by
> increasing a counter on the server and client each time a message is sent/received.
> 
> The spice-protocol patches will be followed by patches for the server and spice-gtk.
> 
> Yonit Halperin (4):
>   Generated enums.h from spice.proto
>   enums.h: add SPICE_MSG_LIST
>   Add support for mini header: an header without sub list & without
>     serial
>   Release 0.10.1
> 
>  NEWS             |    4 ++++
>  configure.ac     |    2 +-
>  spice/enums.h    |    7 +++----
>  spice/protocol.h |   11 ++++++++++-
>  4 files changed, 18 insertions(+), 6 deletions(-)
> 
> -- 
> 1.7.6.4
> 


More information about the Spice-devel mailing list