[Spice-devel] [PATCH 17/17] Add a 'syntax-check' make target

[Daniel P. Berrange]

On Thu, Jan 12, 2012 at 01:47:43PM +0200, Alon Levy wrote:
> On Tue, Jan 10, 2012 at 03:58:38PM +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange at redhat.com>
> > 
> 
> Looked-at-by: Alon Levy <alevy at redhat.com>
> 
> Didn't understand the XXX in cfg.mk, other then that ACK. (comment
> below)


> > +# XXX some of these tools/ programs probably ought to bindtextdomain ?
> > +exclude_file_name_regexp--sc_bindtextdomain = ^server/tests|common/region.c|common/win/my_getopt-1.5/main.c|tools/(bitmap_to_c.c|icon_to_c.c|reds_stat.c)
> > +
> > +exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch]
> > +
> > +exclude_file_name_regexp--sc_const_long_option = ^common/win/my_getopt-1.5/getopt.(3|txt)
> > +
> > +exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^common/win/my_getopt-1.5/getopt.(3|txt)|client/windows/(spice.ico|sticky_alt.bmp)|client/tests/controller_test/build
> > +
> > +# XXX this should be removed & all cases fixde
> > +exclude_file_name_regexp--sc_prohibit_have_config_h = ^*/.*(c|cpp|h)
> 
> Didn't you have a commit adding config.h to files missing it, which I
> took as a precautionary measure (to avoid conflicts in any file with
> definitions in config.h)?

Yes, I added config.h to several files - but that is a separate
check 'sc_require_config_h'.  This particular check is detecting
cases where you have done

  #ifdef HAVE_CONFIG_H
  #include <config.h>
  #endif

which it claims is bogus & should be just

  #include <config.h>

We can probably make this change in spice, but I wanted to double check
that removing the #ifdef would not break the Win32 build - I was unclear
if your Win32 builds have a 'config.h' file or not ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|