[Spice-devel] [PATCH spice-gtk] spice-channel: Allow calling spice_msg_out_send from any context

[Hans de Goede]

Hi,

On 01/17/2012 01:45 PM, Alon Levy wrote:
> On Tue, Jan 17, 2012 at 01:35:21PM +0100, Hans de Goede wrote:
>> spice_msg_out can be not only called from system context and usb event
>> handling thread context, but also from co-routine context. Calling from
>> co-routine context happens when a response gets send synchronously from
>> the handle_msg handler for a certain received packet. This happens with
>> certain usbredir commands.
>>
>> This triggers the following assert in the coroutine code:
>> "GSpice-CRITICAL **: g_coroutine_wakeup: assertion `coroutine !=
>>   g_coroutine_self()' failed"
>>
>> This patch fixes this by making spice_msg_out_send callable from any
>> context and add the same time changing the code to not do unnecessary
> s/add/at/ ?

Yes, good catch, will fix before pushing.

Regards,

Hans