[Spice-devel] [PATCH spice] server: Don't complain if setsockopt NODELAY fails on unix sockets

Daniel P. Berrange berrange at redhat.com
Wed Jan 18 01:57:16 PST 2012


On Wed, Jan 18, 2012 at 10:50:08AM +0100, Hans de Goede wrote:
> With Daniel P. Berrange's patches to allow use of pre-supplied fd's
> as channels, we can no longer be sure that our connections are TCP
> sockets, so it makes no sense to complain if a TCP/IP specific
> setsockopt fails with an errno of ENOTSUP.
> 
> Note that this extends Daniel's commit 492ddb5d1d595e2d12208f4602b18e4432f4e6b4
> which already added the same check to server/inputs_channel.c
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  server/red_tunnel_worker.c |    4 +++-
>  server/red_worker.c        |    4 +++-
>  server/reds.c              |    4 +++-
>  server/snd_worker.c        |    8 ++++++--
>  server/spicevmc.c          |    6 ++++--
>  5 files changed, 19 insertions(+), 7 deletions(-)

ACK, sorry I missed those instances of setsockopt().


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


More information about the Spice-devel mailing list