[Spice-devel] [PATCH spice-gtk] spice-widget: release mouse grab on keyboard-grab-inhibit

[Hans de Goede]

Hi,

On 07/04/2012 02:00 PM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jul 4, 2012 at 9:07 AM, Hans de Goede <hdegoede at redhat.com> wrote:
>> This patch also releases the mouse grab on keyboard-grab-inhibit, fixing
>> the policykit dialog not showing (and thus usb redir not working) when
>> running with server mouse mode. Note that this makes the inhibit-keyboard-grab
>> name of the property no longer really cover what it does, but allas it is
>> part of our ABI...
>
> I suggest this kind of API change be handled gracefully when we can:
> add an addition property such as "inhibit-grabs", and mark the old one
> as deprecated with any of the G_FOO_DEPRECATED macro. The choice of
> keeping old behaviour or changing behaviour for the deprecated method
> is debatable, and is probably case by case. Since you proposed to
> change the behaviour silently, I propose it is changed too for the
> deprecated property anyway.

Adding a second property for this means adding quite a bit of code, for very
little gain. Since the inhibit-keyboard-grab is strictly for internal
use only anyways, and there are no external users that I know of I
suggest that if you want a better name, we simply changing its name
right away. That or live with the current name.

Regards,

Hans