[Spice-devel] [Spice-commits] ...

[Peter Hatina]

Hi,

On 07/02/2012 12:10 PM, Christophe Fergeau wrote:
> Hey Peter,
> 
> Just a few notes after quickly testing this:
> - spice_xpi_generator is a bit unusual, command names generally use '-'
>   instead of '_'
> - spice_xpi_generator --help tells me an arg is required (?)

Both will be fixed.

> - we should update data/test.html with a version generated with
>   spice_xpi_generator. Are they identical?

I was not sure, if we need have the directory "data". If I want, I can
create the page on demand and test the plugin.

> - I'd add a comment at the beginning of the autogenerated page
>   saying that it's autogenerated from idl using the generator
>   found in spice-xpi and that it shouldn't be modified by hand.

Will be fixed.

> 
> Christophe

...

-- 
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno