[Spice-devel] [spice-gtk Win32 v5 16/22] Windows mingw: usb: Dynamically install a libusb driver for USB devices

Marc-André Lureau marcandre.lureau at gmail.com
Mon Jul 9 09:47:18 PDT 2012


Hi

On Mon, Jul 9, 2012 at 2:14 PM, Uri Lublin <uril at redhat.com> wrote:
> +void spice_usb_device_manager_connect_device_async(SpiceUsbDeviceManager *self,
> +                                             SpiceUsbDevice *device,
> +                                             GCancellable *cancellable,
> +                                             GAsyncReadyCallback callback,
> +                                             gpointer user_data)
> +{
> +
> +#if defined(USE_USBREDIR) && defined(G_OS_WIN32)
> +    SpiceWinUsbDriver *installer;
> +    UsbInstallCbInfo *cbinfo;
> +
> +    installer = spice_win_usb_driver_new();
> +    cbinfo = g_new0(UsbInstallCbInfo, 1);

Who is freeing installer? In fact, I think we could simplify the
cbinfo + installer and use just a single object. But we may want to
leave that for a later clean up.

ack, we get fix it from there I think

-- 
Marc-André Lureau


More information about the Spice-devel mailing list