[Spice-devel] [spice-gtk Win32 v5 22/22] usb-device-manager: mingw: ignore "remove" udev event when un/installing a driver

[Marc-André Lureau]

On Mon, Jul 9, 2012 at 2:15 PM, Uri Lublin <uril at redhat.com> wrote:
> ---
>  gtk/usb-device-manager.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
> index 65119ad..2a92ff8 100644
> --- a/gtk/usb-device-manager.c
> +++ b/gtk/usb-device-manager.c
> @@ -719,6 +719,16 @@ static void spice_usb_device_manager_remove_dev(SpiceUsbDeviceManager  *self,
>          return;
>      }
>
> +#ifdef G_OS_WIN32
> +    const guint8 state = spice_usb_device_get_state(device);
> +    if ((state == SPICE_USB_DEVICE_STATE_INSTALLING) ||
> +        (state == SPICE_USB_DEVICE_STATE_UNINSTALLING)) {
> +        g_warning("skipping device at %d.%d. It is installing it's driver",
> +                  bus, address);
> +        return;
> +    }
> +#endif

What happens if the device is removed before it is installed or
uninstalled? Or a simpler case, do we handle correctly removing a
device currently being redirected? (thinking of unplugged abruptely by
user physically)

We could go with that for now, but it looks suspicious to me.

-- 
Marc-André Lureau