[Spice-devel] [PATCH xf86-qxl 07/27] qxl_close_screen: disable fb access, prevent segfaults in uxa later on

Marc-André Lureau marcandre.lureau at gmail.com
Mon Jul 16 08:38:31 PDT 2012


From: Alon Levy <alevy at redhat.com>

I don't have a stacktrace to show any segfault unfortunately.
---
 src/qxl_driver.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 3cf3137..2b0d567 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -638,6 +638,12 @@ qxl_close_screen(CLOSE_SCREEN_ARGS_DECL)
     qxl_screen_t *qxl = pScrn->driverPrivate;
     Bool result;
     
+    ErrorF ("Disabling FB access for %d\n", pScrn->scrnIndex);
+#ifndef XF86_SCRN_INTERFACE
+    pScrn->EnableDisableFBAccess (scrnIndex, FALSE);
+#else
+    pScrn->EnableDisableFBAccess (pScrn, FALSE);
+#endif
     ErrorF ("Freeing %p\n", qxl->fb);
     free(qxl->fb);
     qxl->fb = NULL;
-- 
1.7.10.4



More information about the Spice-devel mailing list