[Spice-devel] [PATCH xf86-qxl 00/27] add arbitrary resolution and multiple monitors

Alon Levy alevy at redhat.com
Tue Jul 17 00:35:59 PDT 2012


On Mon, Jul 16, 2012 at 05:38:24PM +0200, Marc-André Lureau wrote:
> Hi,
> 

ACK to all of your patches. Coding style should be ok'ed by Soren too.

> With this patch series, the QXL driver implements arbitrary
> resolutions and multiple monitors via xrandr interface (to fully test
> this feature, you'll need the related changes in spice-gtk, vdagent,
> and virt-viewer)
> 
> All the patches by Alon are ack'ed by me. Alon already reviewed some
> of my patches over IRC, but didn't officially ack it.
> 
> The most controversial patch is perhaps "Coding style" change, which
> tries to give some consistency but not being as drastic as the recent
> auto-reindent xorg code base. In general, it would be nice to follow
> http://www.x.org/wiki/CodingStyle, but if some devs disagree with this
> change, we can easily skip it.
> 
> Alon Levy (18):
>   whitespace fix
>   uxa: fix bad argument type from removed index API change
>     (s/SCREEN_ARG_TYPE/SCRN_ARG_TYPE/)
>   spiceqxl_inputs: don't hide the pointer global typedef
>   qxl: remove qxl_screen_t->stride
>   fix two segfaults in qxl_free_surface
>   qxl_driver: move mspace_set_*_func earlier
>   qxl_close_screen: disable fb access, prevent segfaults in uxa later
>     on
>   qxl_screen_init: move uxa_resources_init down to after
>     qxl_switch_mode has run
>   spiceqxl_io_port: mark FLUSH_SURFACES_ASYNC as unimplemented, do half
>     of it
>   qxl_surface: normalize surface_send names, add option to
>     surface_destroy to send/not send destroy message
>   qxl_surface: add download_box_no_update
>   qxl_driver: implement randr, arbitrary resolution, multiple monitors
>     (big dump)
>   qxl_driver: introduce qxl_crtc, crtc private
>   qxl_driver: qxl_init_randr: limit width/height to 8192, real check
>     done on randr screen resize callback
>   (for later) qxl_ring: add helpers (debugging/unused)
>   add qxl_edid
>   qxl_driver: add infra for surface0 resizing
>   qxl_driver/qxl_initialize_x_modes: remove modes not fitting
>     framebuffer
> 
> Marc-André Lureau (9):
>   Add some error message if pci revision < 4
>   get rid of one of the gcc warnings
>   Coding style improvement
>   Add check_crtc() helper, to catch crtc/monitor config errors
>   Split crtc_set_mode_major()
>   Avoid calling qxl_update_monitors_config() with invalid config
>   Bypass rrcrtc.c screen size bounds check
>   Change output status when update monitors config
>   Return a preferred mode matching the current mode
> 
>  src/Makefile.am        |    7 +-
>  src/mspace.h           |    2 +-
>  src/qxl.h              |   39 +-
>  src/qxl_driver.c       | 1985 +++++++++++++++++++++++++++++++-----------------
>  src/qxl_edid.c         |  209 +++++
>  src/qxl_ring.c         |   20 +
>  src/qxl_surface.c      |   58 +-
>  src/spiceqxl_inputs.c  |   28 +-
>  src/spiceqxl_io_port.c |    4 +
>  src/uxa/uxa-priv.h     |    2 +-
>  src/uxa/uxa.c          |    5 +-
>  11 files changed, 1615 insertions(+), 744 deletions(-)
>  create mode 100644 src/qxl_edid.c
> 
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list