[Spice-devel] [PATCH spice-server 1/2] server/red_channel: fix possible access to released channel clients

[Alon Levy]

On Mon, Jun 04, 2012 at 02:39:17PM +0200, Christophe Fergeau wrote:
> On Mon, Jun 04, 2012 at 03:26:02PM +0300, Alon Levy wrote:
> > On Mon, Jun 04, 2012 at 11:46:02AM +0200, Christophe Fergeau wrote:
> > > On Thu, May 31, 2012 at 10:04:05AM +0300, Yonit Halperin wrote:
> > > > Added ref count for RedChannel and RedChannelClient.
> > > 
> > > Just a side note, longer term we should probably introduce a
> > > SpiceRefCounted base class which would contain a refcount and a destructor
> > > function, and then we'd be able to use generic ref/unref functions on the
> > > various objects instead of always reimplementing it. One way of doing that
> > > would be to use gobjects, but I don't know how well that would fit within
> > > qemu.
> > 
> > That will fit just fine with qemu, that is using glib for 1.1 and I
> > think since 1.0, so no added dependency.
> 
> Kind of, they are using glib, but went with their own object model instead
> of using gobject.
> 

Yes, I didn't think that's relevant because the only thing qemu should
care from the pov of "would we let spice-server add glib dependency" is
wether this complicates packaging, and the answer is no because qemu
already depends on glib. The fact is we don't expect qemu code to take
references on a spice object - only via the spice.h api, which is
strictly not going to involve passing any GObject I guess, although it
might in the future - but that's a different issue I think.

> Christophe



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel