[Spice-devel] [PATCH v2 2/2] Release 0.11.0

[Alon Levy]

----- Original Message -----
> 
> 
> ----- Original Message -----
> > On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote:
> > > Current bumped and age bumped. Current bumped twice since
> > > previous
> > > values (current = 1, age = 2) were illegal - age must be smaller
> > > or
> > > equal to current, since it's interpreted as meaning our library
> > > supports
> > > t interfaces [current, current - age].
> > > 
> > > New libtool version is thus 3.0.3, since there are added
> > > interfaces:
> > > 
> > >     spice_server_set_name;
> > >     spice_server_set_uuid;
> > >     spice_server_set_listen_socket_fd;
> > >     spice_server_is_server_mouse;
> > > ---
> > >  NEWS         |   33 +++++++++++++++++++++++++++++++++
> > >  configure.ac |    8 ++++----
> > >  2 files changed, 37 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index abe9092..0f5309e 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -10,8 +10,8 @@ AC_PREREQ([2.57])
> > >  # *additionally* follow the rules below for the libtool version.
> > >  
> > >  m4_define([SPICE_MAJOR], 0)
> > > -m4_define([SPICE_MINOR], 10)
> > > -m4_define([SPICE_MICRO], 1)
> > > +m4_define([SPICE_MINOR], 11)
> > > +m4_define([SPICE_MICRO], 0)
> > >  # See info libtool or
> > >  http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> > >  # Here are the 6 rules: (rule 1 here just to avoid saying what I
> > >  omitted)
> > >  
> > > @@ -34,9 +34,9 @@ m4_define([SPICE_MICRO], 1)
> > >  # 6. If any interfaces have been removed or changed since the
> > >  last
> > >  #    public release, then set AGE to 0.
> > >  
> > > -m4_define([SPICE_CURRENT], [1])
> > > +m4_define([SPICE_CURRENT], [3])
> > >  m4_define([SPICE_REVISION], [0])
> > > -m4_define([SPICE_AGE], [2])
> > > +m4_define([SPICE_AGE], [3])
> > 
> > 
> > Unless I'm mis-understanding, I still think this results in a
> > change
> > in SONAME for libspice-server.  IIUC, soname number == AGE -
> > CURRENT,
> > which was previously '1' and is now '0'
> > 
> 
> My mistake - I misread libtool. So the CURRENT is directly used as
> the first, i.e. major, version, and so like you say changing it
> changes the SONAME. So the libtool help is incorrect - current
> should only be incremented on an incompatible change.

A second mistake, this was a result of -version-name and not libtool help being incorrect. So SONAME is indeed current-age. New question: is libspice-server.so.1.3.0 ><= 1.0.2 ?

> 
> I'll do a new revision, more like gtk+/libvirt:
>  - only keep the three above variables
>  - age = minor
>  - revision = micro
>  - current = 1 + major (to not break existing users)
> 
> > Regards,
> > Daniel
> > --
> > |: http://berrange.com      -o-
> > |   http://www.flickr.com/photos/dberrange/ :|
> > |: http://libvirt.org              -o-
> > |            http://virt-manager.org :|
> > |: http://autobuild.org       -o-
> > |        http://search.cpan.org/~danberr/ :|
> > |: http://entangle-photo.org       -o-
> > |      http://live.gnome.org/gtk-vnc :|
> > 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>