[Spice-devel] [spice-gtk] Fix various memory leaks

Christophe Fergeau cfergeau at redhat.com
Wed Jun 13 03:42:16 PDT 2012


On Wed, Jun 13, 2012 at 01:37:22PM +0300, Alon Levy wrote:
> > diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c
> > index 26a71a4..a6ef38c 100644
> > --- a/gtk/vncdisplaykeymap.c
> > +++ b/gtk/vncdisplaykeymap.c
> > @@ -159,7 +159,7 @@ const guint16 const *vnc_display_keymap_gdk2xtkbd_table(size_t *maplen)
> >  				if (!keycodes)
> >  					g_warning("could not lookup keycode name");
> >  			}
> > -			XkbFreeClientMap(desc, XkbGBN_AllComponentsMask, True);
> > +			XkbFreeKeyboard(desc, XkbGBN_AllComponentsMask, True);
> 
> Probably worth to hunt down the original copy and fix that too.

I've checked it's the case before including this fix
http://git.gnome.org/browse/gtk-vnc/commit/?id=229c1061b3fbe34911d8f7b42a3a87c9b8f15931
I'm assuming this is the original copy, but I wouldn't be surprised if I
was wrong ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120613/aed64de4/attachment.pgp>


More information about the Spice-devel mailing list