[Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

[Marc-André Lureau]

Hi


On Wed, Jun 13, 2012 at 7:07 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> We need to integrate closely with the desktop environment of the user in
> several cases. Some examples are disabling auto-mounting when auto-usbredir
> is active (rhbz#812972), and disabling the screensaver when fullscreen
> (fdo#34793).
>
> Unfortuntely these kinds of things require desktop environment specific
> handling. Therefor this patch introduces a desktop-integration helper class,
> which is to server as a container for all sort of desktop environment specific
> functions.
>
> For now it just supports disabling automounting under Gnome-3, another patch
> extending it to also support disabling automounting under Gnome-2 is in the
> pipeline.

Looks reasonable to me, however, I don't see why it should be in
spice-glib, since it's very much desktop related. Wouldn't it make
more sense in spice-gtk? Since it's not directly dependent and related
to a particular spice session, it could perhaps even be a separate
library (although for now, a few extra functions and dependency in
spice-gtk is surely fine).

-- 
Marc-André Lureau