[Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

[Hans de Goede]

Hi,

On 06/14/2012 11:28 AM, Marc-André Lureau wrote:
> Hi
>
> ----- Mensaje original -----
>>> Looks reasonable to me, however, I don't see why it should be in
>>> spice-glib, since it's very much desktop related.  Wouldn't it make
>>> more sense in spice-gtk?
>>
>> I actually put it in spice-gtk at first, but that does not work very
>> well because usb-device-manager needs access to the automount disable
>> functionality.
>
> Ok
>
>>> Since it's not directly dependent and related
>>> to a particular spice session, it could perhaps even be a separate
>>> library (although for now, a few extra functions and dependency in
>>> spice-gtk is surely fine).
>>
>> There is various state inside, which needs to be coupled to some
>> object, using the session for this seems best.
>
> Except setting/getting its own SpiceDesktopIntegration *desktop_integration; what does it need from SpiceSession?

Nothing.

> If I understand correctly, the changes made by desktop-integration are session-wide

Correct.

> so why having a 1-1 relation with each spice session?

We also need to undo the changes at some point in time, iow the desktop-integration objects
lifetime needs to be coupled to *something*, and spice-session seems best for this. IE,
think usage in python from virt-manager, when the vm viewing window is closed (which does
not necessarily end the virt-manager process) we want to restore the settings.

Regards,

Hans