[Spice-devel] [PATCH] make celt to be optional

[Michael Tokarev]

14.06.2012 18:23, David Mansfield wrote:
[]
> As a user, being given the information and the option to disable is the best case.  A message saying "No compressed audio codec is available.  Continuing with audio enabled may degrade performance.  Disable audio for this sesison?"

I wonder which popup you're talking about.  Is that in client?
Because if you're talking about the server, it is not the most
smart idea to ask someone if he wants to disable audio, during
headless system startup.

If the talk is about the client, the server patch (the one which
this thread is about) can still be applied, how do you think?
This might need a bit more investigation, ie, how the server
part will react if the application (the server, eg qemu) explicitly
enabled audio compression.  But at least no popups there should
be added.

Will you help adding such a dialog (and a proper setting too, to be
able to shut it off) to client software, eg, to spice-gtk client for
which Lian posted a patch making celt optional?  This needs to be
done really fast if there's a chance still to get this stuff into
the next debian release.

> This would inform, and allow a user on a LAN to proceed or not, and give them enough info to get a head start googling for the problem.  A debian user still could install the necessary libraries his/her self and get the desired performance, given the information in the popup.
> 
> Silently using PCM would suck.  Silently disabling audio would suck. IMHO.

Well, requiring answering an annoying question every time you start
an app is even more sucky, in my opinion.  If that'd be the case,
I'd go and fix the code by commenting out this dialog altogther.

My opinion is that the the whole issue isn't worth this and other
similar discussions already, it is not a use case important enough
to receive so much attention.

And I'm about to give up, too, just disabling spice if spice guys
don't want it to be shipped in popular distributions.

Thanks,

/mjt