[Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

[Christophe Fergeau]

On Wed, Jun 20, 2012 at 04:23:30PM +0300, Alon Levy wrote:
> On Wed, Jun 20, 2012 at 01:18:10PM +0200, Christophe Fergeau wrote:
> > On Thu, Jun 14, 2012 at 02:03:25PM +0300, Alon Levy wrote:
> > > This file was hand generated until now, resulting in the wierd situation where
> > > it is different for spice-gtk and spice-server even though they both use the
> > > same spice-common and spice-protocol (or at least close) versions.
> > > 
> > > This patch generates the enums.h files from spice-common. While that file is
> > > actually in the spice-protocol submodule, it cannot be generated from
> > > spice-protocol since it lacks access to spice.proto and spice_codegen.py.
> > 
> > yeah, a bit ugly :-/
> 
> How about this: I move the rule into spice-protocol. It will check if
> it's parent directory is spice-common, specifically just check for
> spice.proto and spice_codegen.py, and if so it will update enums.h. That
> should also fix make distcheck.

I think I prefer the current patch ;)

> 
> > 
> > > So in
> > > affect whenvever it will differ the spice-protocol module will become dirty and
> > > hence hopefully commited with the new enums.h.
> > 
> > spice-protocol/spice-common are always dirty here even when I don't modify
> > them, so I wouldn't place my hopes too high on this being noticed.
> 
> This is a seperate issue, I have it to. It is a result of the .gitignore
> (that we generate from git.mk) missing some files.

Yeah I know it has nothing to do with your changes, what I meant is that we
won't necessarily notice enums.h needs updating since
spice-common/spice-protocol tend to always be dirty for other reasons.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120620/c3826aec/attachment.pgp>