[Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

Hans de Goede hdegoede at redhat.com
Sat Jun 23 16:39:25 PDT 2012


Hi,

On 06/23/2012 02:46 PM, Marc-André Lureau wrote:
> On Sat, Jun 23, 2012 at 9:05 AM, Hans de Goede <hdegoede at redhat.com> wrote:
>> Passing, what for all intends and purposes is a *fake* toplevel window id,
>> is just gaming the system, this is not how the inhibit API is supposed to
>> be used! The whole toplevel id is there to avoid inhibits sticking around
>> when they should not. And we should simply not try to game the system!
>
> There is no game

??

 > it can be simplified, resulting in simpler API and less code.

No it cannot, using a hidden window for this is just plain wrong! One is
supposed to use real toplevel windows with the inhibit API.

Regards,

Hans


More information about the Spice-devel mailing list