[Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

[Hans de Goede]

Hi,

On 06/24/2012 02:07 AM, Marc-André Lureau wrote:
> Hi
>
> On Sun, Jun 24, 2012 at 1:39 AM, Hans de Goede <hdegoede at redhat.com> wrote:
>>> it can be simplified, resulting in simpler API and less code.
>>
>> No it cannot, using a hidden window for this is just plain wrong! One is
>> supposed to use real toplevel windows with the inhibit API.
>>
>
> Well, in fact that toplevel_xid is optionnal, and is used for
> eventually taking application screenshots (only if possible).

Oh, I was under the impression that the xid would be used to monitor the
window going away and automatically uninhibit when it is gone. Since that
is not the case I agree with you that just using a single inhibit with a
xid of 0 and ref-counting is much better. I'll rewrite my patch-set to
work this way tomorrow.

Regards,

Hans