[Spice-devel] make qemu-kvm dependent on spice-protocol or spice-gtk on spice-server?

[David Jaša]

Hi,

I tried to look into the code to see how these RFEs could be
implemented:
https://bugzilla.redhat.com/show_bug.cgi?id=787185 (qemu-kvm)
https://bugzilla.redhat.com/show_bug.cgi?id=834513 (spice-gtk)

and I found that the channel names are actually defined in spice-server
code:
http://cgit.freedesktop.org/spice/spice/tree/server/reds.c#n3959

That's fine for qemu-kvm because it includes spice.h of spice server,
but spice-gtk includes just stuff from spice-protocol.

What is lesser pain to do, move the channel names to spice-protocol and
add the spice-protocol includes to qemu code or to include spice-server
heades in spice-gtk too.

It seems to me that it the most logical is to move the channel names to
spice-protocol to keep them near the channel codes that are defined
here:
http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/enums.h#n337
but I don't really understand the problem enough so I'l like to hear
more opinions.

David

-- 

David Jaša, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24