[Spice-devel] [PATCH spice 4/4] build-sys: fix make distcheck

Marc-André Lureau marcandre.lureau at gmail.com
Thu Mar 1 03:20:02 PST 2012


- Do not refer to .c files managed by another makefile (this will fail
  make distclean)
- Do not refer to files by relative path (should use $top_srcdir for ex)
- Use LDADD for object linking instead of LDFLAGS, for linker flags
---
 server/tests/Makefile.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index 31c8372..61fad75 100644
--- a/server/tests/Makefile.am
+++ b/server/tests/Makefile.am
@@ -13,12 +13,12 @@ if SUPPORT_AUTOMATED_TESTS
 INCLUDES += -DAUTOMATED_TESTS
 endif
 
-AM_LDFLAGS =						\
+LDADD =							\
+	$(top_builddir)/common/libspice-common.la	\
 	$(top_builddir)/server/libspice-server.la	\
 	$(NULL)
 
 COMMON_BASE =					\
-	../../common/backtrace.c		\
 	basic_event_loop.c			\
 	basic_event_loop.h			\
 	test_util.h				\
-- 
1.7.7.6



More information about the Spice-devel mailing list