[Spice-devel] [PATCH 00/20] vdagent mingw compilation

Alon Levy alevy at redhat.com
Thu Mar 1 03:53:14 PST 2012


On Thu, Mar 01, 2012 at 11:17:34AM +0100, Christophe Fergeau wrote:
> Hi,
> 

ACK series, just one suggestion for the std::min/max issue.

> This patch series fixes most of the issues I had when trying to compile
> vdagent-win with mingw. It also adds an autotools-based build system since
> as a more convenient way of building with mingw.
> With these patches, vdagent can nearly be compiled using mingw.
> There are still a few pending issues related to unicode support, and
> no handling of windows resources.
> I've tested that this doesn't break VisualC++ builds.
> 
> Christophe
> 
> 
> Christophe Fergeau (20):
>   mingw: fix format string warnings
>   mingw: don't redefine SIZE_MAX
>   mingw: disable vc-specific #pragma
>   mingw: use gcc attributes for struct packing
>   mingw: use explicit std:: namespace for min/max
>   mingw: fix header case
>   mingw: remove unused variable
>   mingw: fix initialization list order for VDAgent()
>   mingw: use unsigned int in for loops when needed
>   mingw: workaround "use of unitialized var" warning
>   mingw: fix signed/unsigned comparison warning
>   mingw: workaround ximage.h #defining min/max
>   mingw: don't redefine CTL_CODE if it's already defined
>   mingw: use const char * in DisplaySetting()
>   mingw: fix another signed/unsigned warning
>   mingw: fix format string for wchar_t
>   mingw: add autotools build system
>   mingw: workaround _ftime_s bug
>   mingw: make sure unicode support is enabled
>   mingw: add Visual C++ files to EXTRA_DIST
> 
>  Makefile.am                   |   48 ++++++++++
>  common/stdint.h               |    2 +
>  common/vdcommon.h             |   14 +++-
>  common/vdlog.cpp              |    2 +-
>  common/vdlog.h                |   10 ++-
>  configure.ac                  |   87 ++++++++++++++++++
>  git.mk                        |  200 +++++++++++++++++++++++++++++++++++++++++
>  vdagent/desktop_layout.cpp    |   40 +++++++--
>  vdagent/display_setting.cpp   |   55 ++++++------
>  vdagent/display_setting.h     |    2 +-
>  vdagent/vdagent.cpp           |   76 ++++++++--------
>  vdservice/pci_vdi_port.cpp    |    9 ++-
>  vdservice/vdi_port.cpp        |    2 +-
>  vdservice/vdservice.cpp       |   50 +++++-----
>  vdservice/virtio_vdi_port.cpp |   10 +-
>  15 files changed, 495 insertions(+), 112 deletions(-)
>  create mode 100644 Makefile.am
>  create mode 100644 configure.ac
>  create mode 100644 git.mk
> 
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list