[Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

[Marc-André Lureau]

Christophe, are you okay with the changes then?

(I also would like to have a more generic "string" -> "value"
dictionnary support for this kind of data, but the
marshaller/demarshaller/proto doesn't know how to handle that, and
that seems to be really less trivial than the proposed addition)

On Fri, Mar 2, 2012 at 7:37 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> Looks good, ack.
>
> Regards,
>
> Hans
>
>
>
> On 03/02/2012 01:46 PM, Marc-André Lureau wrote:
>>
>> This allows the client to identify a Spice server. This can be useful
>> to associate data/configuration with this particular server.
>>
>> The corresponding main channel messages are:
>>
>>     message {
>>        uint8 uuid[16];
>>     } uuid;
>>
>>     message {
>>        uint32 name_len;
>>        uint8 name[name_len]; /* should be \0 terminated */
>>     } name;
>>
>> Those messages are sent by the server only if the corresponding
>> capabilities SPICE_MAIN_CAP_NAME, and SPICE_MAIN_CAP_UUID are
>> available on the client.
>> ---
>>  spice/enums.h    |    2 ++
>>  spice/protocol.h |    2 ++
>>  2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/spice/enums.h b/spice/enums.h
>> index 7325180..d2dbfd0 100644
>> --- a/spice/enums.h
>> +++ b/spice/enums.h
>> @@ -367,6 +367,8 @@ enum {
>>      SPICE_MSG_MAIN_AGENT_TOKEN,
>>      SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST,
>>      SPICE_MSG_MAIN_MIGRATE_END,
>> +    SPICE_MSG_MAIN_NAME,
>> +    SPICE_MSG_MAIN_UUID,
>>
>>      SPICE_MSG_END_MAIN
>>  };
>> diff --git a/spice/protocol.h b/spice/protocol.h
>> index 5c7f286..ad38726 100644
>> --- a/spice/protocol.h
>> +++ b/spice/protocol.h
>> @@ -119,6 +119,8 @@ enum {
>>
>>  enum {
>>      SPICE_MAIN_CAP_SEMI_SEAMLESS_MIGRATE,
>> +    SPICE_MAIN_CAP_NAME,
>> +    SPICE_MAIN_CAP_UUID,
>>  };
>>
>>  #include<spice/end-packed.h>



-- 
Marc-André Lureau