[Spice-devel] [PATCH] Remove unused Canvas members

[Alon Levy]

On Mon, Mar 05, 2012 at 10:22:15AM +0100, Christophe Fergeau wrote:
> The various Canvas have _max and _base variables which are not
> used, better to remove them.



> ---
>  client/canvas.cpp       |    1 -
>  client/canvas.h         |    1 -
>  client/red_gdi_canvas.h |    2 --
>  client/red_sw_canvas.h  |    2 --
>  4 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/client/canvas.cpp b/client/canvas.cpp
> index 0986d47..7d1561a 100644
> --- a/client/canvas.cpp
> +++ b/client/canvas.cpp
> @@ -70,7 +70,6 @@ void Canvas::clear()
>  
>  void Canvas::begin_draw(SpiceMsgDisplayBase& base, int size, size_t min_size)
>  {
> -    _base = (uintptr_t)&base;
>  }
>  
>  void Canvas::draw_fill(SpiceMsgDisplayDrawFill& fill, int size)
> diff --git a/client/canvas.h b/client/canvas.h
> index 5a34bdc..66a5f1d 100644
> --- a/client/canvas.h
> +++ b/client/canvas.h
> @@ -344,7 +344,6 @@ private:
>  
>      SurfacesCache& _surfaces_cache;
>  
> -    unsigned long _base;
>      unsigned long _max;

Why did you leave this _max?

>  };
>  
> diff --git a/client/red_gdi_canvas.h b/client/red_gdi_canvas.h
> index fa173c4..77adcf7 100644
> --- a/client/red_gdi_canvas.h
> +++ b/client/red_gdi_canvas.h
> @@ -48,8 +48,6 @@ private:
>      RedPixmapGdi *_helper_pixmap;
>      HDC _dc;
>      HBITMAP _prev_bitmap;
> -    unsigned long _base;
> -    unsigned long _max;
>  };
>  
>  #endif
> diff --git a/client/red_sw_canvas.h b/client/red_sw_canvas.h
> index 4736649..eb577ac 100644
> --- a/client/red_sw_canvas.h
> +++ b/client/red_sw_canvas.h
> @@ -45,8 +45,6 @@ public:
>  
>  private:
>      RedPixmap *_pixmap;
> -    unsigned long _base;
> -    unsigned long _max;
>  };
>  
>  #endif
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel