[Spice-devel] [spice-xpi 1/4] Add nsPluginInstance::SendBool

[Uri Lublin]

On 03/05/2012 03:33 PM, Christophe Fergeau wrote:
> ::SendVal will not send messages when the value is 0, which is not
> what is expected when sending a boolean value.
> ---
>  SpiceXPI/src/plugin/plugin.cpp |    6 ++++++
>  SpiceXPI/src/plugin/plugin.h   |    1 +
>  2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
> index 2860d5e..cfa70cd 100644
> --- a/SpiceXPI/src/plugin/plugin.cpp
> +++ b/SpiceXPI/src/plugin/plugin.cpp
> @@ -515,6 +515,12 @@ void nsPluginInstance::SendValue(uint32_t id, uint32_t value)
>      WriteToPipe(&msg, sizeof(msg));
>  }
>  

Ack series.

I'm suggesting to make send-ctrl-alt-delete true by default.
This way the default is not changed (was true before that patch-set),
and I think that's a more intuitive behavior.