[Spice-devel] [PATCH spice-gtk 1/3] build: move @SPICE_GLIB_REQUIRES@ to Requires.private

Alon Levy alevy at redhat.com
Wed Mar 7 12:16:48 PST 2012


On Wed, Mar 07, 2012 at 09:09:33PM +0100, Marc-André Lureau wrote:
> The libraries listed in Requires aren't needed during build time, they
> are library depedencies. And since this is only needed if linking
> statically, we can safely move them to Requires.private.
> 
> Succesfully tested change with compilation against virt-viewer.
> 
> Later, this will also help fixing bug rhbz #799112.

Cool, didn't know you could do that. Btw, totally unrelated, but you
think we should add spice-protocol as a submodule to qemu as well?

> ---
>  spice-client-glib-2.0.pc.in |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/spice-client-glib-2.0.pc.in b/spice-client-glib-2.0.pc.in
> index 738862e..27d6886 100644
> --- a/spice-client-glib-2.0.pc.in
> +++ b/spice-client-glib-2.0.pc.in
> @@ -7,6 +7,7 @@ Name: spice-client-glib-2.0
>  Description: SPICE Client GLib 2.0 library
>  Version: @VERSION@
>  
> -Requires: @SPICE_GLIB_REQUIRES@ spice-protocol
> +Requires: spice-protocol
> +Requires.private: @SPICE_GLIB_REQUIRES@
>  Libs: -L${libdir} -lspice-client-glib-2.0
>  Cflags: -I${includedir}/spice-client-glib-2.0
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list