[Spice-devel] [PATCH spice-gtk 1/3] build: move @SPICE_GLIB_REQUIRES@ to Requires.private

[Alon Levy]

On Wed, Mar 07, 2012 at 08:42:54PM +0000, Daniel P. Berrange wrote:
> On Wed, Mar 07, 2012 at 10:16:48PM +0200, Alon Levy wrote:
> > On Wed, Mar 07, 2012 at 09:09:33PM +0100, Marc-André Lureau wrote:
> > > The libraries listed in Requires aren't needed during build time, they
> > > are library depedencies. And since this is only needed if linking
> > > statically, we can safely move them to Requires.private.
> > > 
> > > Succesfully tested change with compilation against virt-viewer.
> > > 
> > > Later, this will also help fixing bug rhbz #799112.
> > 
> > Cool, didn't know you could do that. Btw, totally unrelated, but you
> > think we should add spice-protocol as a submodule to qemu as well?
> 
> Does QEMU actually need it directly ?  QEMU depends on spice-server,
> which should already have pulled in the spice-protocol headers
> indirectly.  So if spice-server has spice-protocol as a GIT submodule,
> QEMU shouldn't need it IIUC

qemu uses spice-protocol definitions directly, and spice-server
doesn't install the spice-protocol headers. We could have it install
them, but then it would fix those versions at the time of installation.

> 
> Regards,
> Daniel
> -- 
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel