[Spice-devel] Fix red_worker threads consuming 100% cpu when a client is connected (v2)

Alon Levy alevy at redhat.com
Sun Mar 11 00:53:36 PST 2012


On Sat, Mar 10, 2012 at 08:31:24PM +0100, Hans de Goede wrote:
> Hi All,
> 

ACK series. Great fix/cleanup, tested by me too.

> This patch series fixes an issue where red_worker thread consume as much CPU
> as they can get when a client is connected (the interesting part explaining
> what is going on is in the 4th patch.
> 
> New in v2 is fixing the regression where multi head would crash, which
> did turn out to be a problem with this patch set. The problem as that
> listen_to_new_client_channel() did more then the name suggested, besides
> adding the EventListener, it also contained one small, arguably misplaced,
> but important line:
>     common_cc->id = common->worker->id;
> 
> In v2 this line is moved to common_channel_client_create(), where it should
> have been from the beginning IMNSHO, fixing the multi head issues.
> 
> Regards,
> 
> Hans
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list