[Spice-devel] spice-xpi

[Peter Hatina]

On 03/13/2012 01:45 PM, Marc-André Lureau wrote:
> 
> 
> ----- Mensaje original -----
>> Hi,
>>
>> as Marc-Andre has decided to drop log4cpp, I would like to at least
> 
> It was publicly acked by several people in the team.
> 
>> revert the part of the message format. The reason is simple, Spice-QA
>> guys are developing a test framework, which uses the log4cpp format
>> we had.
> 
> And I gave reasons why it's a good thing to remove log4cpp, and why we should not dump to disk and rely on external configuration files, external libraries, and practices that are not common in the desktop.
> 
> If Spice-QA want to develop it's own test framework, they should rely on glib log handler, since it's used by various applications, including spice-gtk and virt-viewer. And if they really need log4cpp, I would really like to know what glog handler is missing.
> 
>> Opinions?
> 
> I discussed with you on IRC that we should instead use g_log / g_debug / g_warning equivalent, with proper domain when necessary. I thought you agree, that's why I am a bit surprised.

glog is missing the "modified" method name, which is added by the patch.
QA guys rely especially on the method name.

I am not against dropping log4cpp.

-- 
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno