[Spice-devel] spice-xpi

[Peter Hatina]

On 03/13/2012 01:26 PM, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Mar 13, 2012 at 12:29:01PM +0100, Peter Hatina wrote:
>> Hi,
>> 
>> as Marc-Andre has decided to drop log4cpp, I would like to at
>> least revert the part of the message format. The reason is
>> simple, Spice-QA guys are developing a test framework, which uses
>> the log4cpp format we had.
>> 
>> Opinions?
> 
> There seems to have several things mixed in this patch, this
> (re?)adds logging in some places, this wraps use of g_debug/... in
> LOG_DEBUG/..., and there is another change replacing execl use with
> execv. If I understand things correctly, your main goal is to use
> the same message formatting as before to avoid breaking the parsing
> QE is doing on these messages, right? Could you split the log
> additions in a separate patch? Apart from this, no strong
> opposition from me if this doesn't spam stdin/stdout but only log a
> few useful messages during spice-xpi runtime.
> 
> Christophe
> 

The change from execl to execv is due to message output. I consider
this to be still in one domain - adding log messages.

-- 
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno