[Spice-devel] spice-xpi

[Marian Krcmarik]

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Marc-André Lureau" <mlureau at redhat.com>
> Cc: spice-devel at lists.freedesktop.org
> Sent: Tuesday, March 13, 2012 2:02:33 PM
> Subject: Re: [Spice-devel] spice-xpi
> 
> On Tue, Mar 13, 2012 at 08:58:26AM -0400, Marc-André Lureau wrote:
> > 
> > 
> > ----- Mensaje original -----
> > > glog is missing the "modified" method name, which is added by the
> > > patch.
> > > QA guys rely especially on the method name.
> > 
> > That's the problem: we can't refactor, rename function, add
> > arguments or
> > change order of things, or even perhaps add more debugging. This
> > smells
> > wrong. We can't guarantee the debugging messages won't break... We
> > need
> > something else imho, perhaps like tracing point etc?
> 
> I think they are exploring using systemtap too. In the mean time, it
> doesn't really hurt to have more expressive logs messages, and logs
> in
> places where it might be useful...
> 
> Christophe
Exactly.
1. We do not test functionality, we just check that values passed to controller from oVirt portals are correct which save us time when functionality itself is not broken but wrong values were passed so It behaves differently.
2. Whatever tests you have, you need to maintain them, They break often, It's naive to think you do not have to, especially when you are changing components and functionality every release as It is happing in Spice project. If the logging breaks a test and test fails, so? Nothing happens, you will check. Every single test depends on something, on framework, on environment, etc.. Anything can be broken, and It happens often. The biggest problem is when you get passed results which should be failed.
3. As Christophe said, we already had that covered by systemtap, but It's the same story, If you change code It could be broken as well.
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>