[Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

Daniel P. Berrange berrange at redhat.com
Tue Mar 13 06:51:56 PDT 2012


On Tue, Mar 13, 2012 at 01:40:12PM +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> A few functions have very large arrays declared on the stack.
> Replace these with heap allocations, to reduce risk of stack
> overflows in deep callpaths
> ---
>  gtk/channel-playback.c |    6 ++++--
>  gtk/spice-channel.c    |   16 ++++++++++++----
>  2 files changed, 16 insertions(+), 6 deletions(-)

Urgh, this patch was a bit messed up - a missing 'g_free' and an unrelated
change. Consider this one replaced by the following two patches



More information about the Spice-devel mailing list