[Spice-devel] [PATCH spice-gtk 00/15] Expand usage of compiler warnings

[Daniel P. Berrange]

On Tue, Mar 13, 2012 at 03:00:04PM +0100, Hans de Goede wrote:
> Hi,
> 
> Series looks good. I've a few remarks on patch 14/15 though. Also
> if you're enable ssp why not also add -DFORTIFY_SOURCE=2 ?

We do actually, but not via a compile flag. Instead it uses
AC_DEFINE(_FORTIFY_SOURCE, 2), which causes it to appear in
config.h. Since every source file includes config.h, this
is equivalent.

FYI, to make it easier to consume, I have pushed a revised patch
series to:

  https://gitorious.org/~berrange/virt-tools/berrange-spice-gtk

Patch 14 is fixed to remove the stack allocation stuff, and
Patch 15 is changed to set the stack limit to 9216 instead
of 1024

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|