[Spice-devel] [PATCH spice-gtk 00/15] Expand usage of compiler warnings

[Marc-André Lureau]

Daniel,

Here is a couple of patches that fixes deprecation warning/errors to
be applied on top of your series after review. They fix compilation
with mingw.

On Tue, Mar 13, 2012 at 3:46 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Tue, Mar 13, 2012 at 03:33:46PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 03/13/2012 03:23 PM, Daniel P. Berrange wrote:
>> >On Tue, Mar 13, 2012 at 03:00:04PM +0100, Hans de Goede wrote:
>> >>Hi,
>> >>
>> >>Series looks good. I've a few remarks on patch 14/15 though. Also
>> >>if you're enable ssp why not also add -DFORTIFY_SOURCE=2 ?
>> >
>> >We do actually, but not via a compile flag. Instead it uses
>> >AC_DEFINE(_FORTIFY_SOURCE, 2), which causes it to appear in
>> >config.h. Since every source file includes config.h, this
>> >is equivalent.
>> >
>> >FYI, to make it easier to consume, I have pushed a revised patch
>> >series to:
>> >
>> >   https://gitorious.org/~berrange/virt-tools/berrange-spice-gtk
>> >
>>
>> Looks good, ack series.
>>
>> Don't you have commit rights on spice-gtk yet? If not I think
>> it is time you get them :)  Marc-André, do you agree? If so
>> one of us needs to file a bug here:
>> https://bugs.freedesktop.org/enter_bug.cgi?product=freedesktop.org
>>
>> component administration Requesting Daniel to be added to the
>> spice group. Daniel, what is your freedesktop.org username?
>
> I wish I had a fdo account. Still waiting for anyone to respond to the
> request I put in weeks ago....
>
> https://bugs.freedesktop.org/show_bug.cgi?id=45767
>
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-deprecation-warnings.patch
Type: text/x-patch
Size: 6352 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120314/c2c71acc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-Werror-format-with-mingw.patch
Type: text/x-patch
Size: 1536 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120314/c2c71acc/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-libintl_printf-is-an-unrecognized-format-functio.patch
Type: text/x-patch
Size: 951 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120314/c2c71acc/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Use-GTK_DISABLE_DEPRECATED-to-avoid-inclusion-of-pro.patch
Type: text/x-patch
Size: 4358 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120314/c2c71acc/attachment-0003.bin>