[Spice-devel] [PATCH spice-xpi] ~/.spicec is no longer needed

[Peter Hatina]

On 03/13/2012 06:40 PM, Alon Levy wrote:
> On Tue, Mar 13, 2012 at 05:39:51PM +0100, Marc-André Lureau wrote:
>> ping
>>
> 
> I'm just not sure about this - maybe someone who actually uses spice-xpi
> can say something about it?
> 
>> On Fri, Mar 9, 2012 at 7:20 PM, Marc-André Lureau
>> <marcandre.lureau at gmail.com> wrote:
>>> Don't attempt to create an unused directory
>>> See also: https://bugzilla.redhat.com/show_bug.cgi?id=801871
>>> ---
>>>  SpiceXPI/src/plugin/plugin.cpp |    5 -----
>>>  SpiceXPI/src/plugin/plugin.h   |    1 -
>>>  2 files changed, 0 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
>>> index 39f2e81..4dc1121 100644
>>> --- a/SpiceXPI/src/plugin/plugin.cpp
>>> +++ b/SpiceXPI/src/plugin/plugin.cpp
>>> @@ -189,11 +189,6 @@ nsPluginInstance::nsPluginInstance(NPP aInstance):
>>>     m_initialized(PR_FALSE),
>>>     m_scriptable_peer(NULL)
>>>  {
>>> -    // create .spicec directory in $HOME
>>> -    m_home_dir = getenv("HOME");
>>> -    m_home_dir += "/.spicec";
>>> -    mkdir(m_home_dir.c_str(), S_IRWXU);
>>> -
>>>     // create temporary directory in /tmp
>>>     char tmp_dir[] = "/tmp/spicec-XXXXXX";
>>>     m_tmp_dir = mkdtemp(tmp_dir);
>>> diff --git a/SpiceXPI/src/plugin/plugin.h b/SpiceXPI/src/plugin/plugin.h
>>> index 8481120..42e2a2d 100644
>>> --- a/SpiceXPI/src/plugin/plugin.h
>>> +++ b/SpiceXPI/src/plugin/plugin.h
>>> @@ -204,7 +204,6 @@ private:
>>>     std::map<std::string, std::string> m_language;
>>>
>>>     NPObject *m_scriptable_peer;
>>> -    std::string m_home_dir;
>>>     std::string m_tmp_dir;
>>>     std::string m_trust_store_file;
>>>  };
>>> --
>>> 1.7.7.6
>>>
>>
>>
>>
>> -- 
>> Marc-André Lureau
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Ack, if there is no log file placed in ~/.spicec, the directory is
useless from spice-xpi point of view.

-- 
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno