[Spice-devel] [PATCH spice-gtk] Move undef FORTIFY below config.h

Daniel P. Berrange berrange at redhat.com
Wed Mar 14 14:21:52 PDT 2012


On Wed, Mar 14, 2012 at 08:43:20PM +0100, Marc-André Lureau wrote:
> It used to be below, then was moved on top of all, but now it's
> defined in config.h. Hopefully below config.h is the right
> place. config.h should never have direct includes anyway.
> ---
>  gtk/continuation.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gtk/continuation.c b/gtk/continuation.c
> index fa958b9..2891a25 100644
> --- a/gtk/continuation.c
> +++ b/gtk/continuation.c
> @@ -17,10 +17,10 @@
>   * License along with this library; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
>   */
> -#undef _FORTIFY_SOURCE
> -
>  #include <config.h>
>  
> +#undef _FORTIFY_SOURCE
> +
>  #include "continuation.h"
>  
>  /*

ACK, config.h must always be the first thing in any .c file

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


More information about the Spice-devel mailing list