[Spice-devel] Failing to compile spice-gtk: generated_marshallers1.c:2:25: fatal error: marshallers.h: No such file or directory

[Alon Levy]

On Mon, Mar 19, 2012 at 07:02:17AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > On Mon, Mar 19, 2012 at 12:11:35PM +0200, Yaniv Kaul wrote:
> > > On 03/19/2012 12:01 PM, Marc-André Lureau wrote:
> > > >Hi
> > > >
> > > >The generated files need to be regenerated. I guess they should
> > > >have
> > > >build depedency on Makefile somehow..
> > > >
> > > >anyway, as in countless times with build issues: git clean -dfx
> > > >should
> > > >get you out of trouble.
> > >
> > > It's only project I work on with which I'm having such issues with
> > > each time. I thought 'make clean ; ./autogen.sh' would have solved
> > > it. Alas, it didn't.
> > > I was not aware of 'git clean' - that worked - thanks!
> > > Y.
> >
> > So those files are not in the clean target, they should be. And I
> > think
> > you haven't used enough projects if this is the only one :P
> 
> Our goal is to maintain git clone && ./autogen && make distcheck working. The rest is superflous.
> 
> "make clean" shouldn't remove generated files.
> 
> However the generated file should somehow have dependencies on Makefile.am.

In this case that would mean adding a dependency on Makefile - does that
make sense?

--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -19,7 +19,7 @@ INCLUDES = \
 
 spice_built_sources = generated_marshallers.c generated_marshallers.h generated_demarshallers.c
 
-generated_demarshallers.c: $(top_srcdir)/spice.proto
+generated_demarshallers.c: $(top_srcdir)/spice.proto Makefile.am