[Spice-devel] [spice PATCHv2] Remove unused Canvas members

Hans de Goede hdegoede at redhat.com
Tue Mar 20 08:50:12 PDT 2012


Ack.

On 03/20/2012 04:33 PM, Christophe Fergeau wrote:
> The various Canvas have _max and _base variables which are not
> used, better to remove them.
> ---
>   client/canvas.cpp       |    1 -
>   client/canvas.h         |    3 ---
>   client/red_gdi_canvas.h |    2 --
>   client/red_sw_canvas.h  |    2 --
>   4 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/client/canvas.cpp b/client/canvas.cpp
> index 0986d47..7d1561a 100644
> --- a/client/canvas.cpp
> +++ b/client/canvas.cpp
> @@ -70,7 +70,6 @@ void Canvas::clear()
>
>   void Canvas::begin_draw(SpiceMsgDisplayBase&  base, int size, size_t min_size)
>   {
> -    _base = (uintptr_t)&base;
>   }
>
>   void Canvas::draw_fill(SpiceMsgDisplayDrawFill&  fill, int size)
> diff --git a/client/canvas.h b/client/canvas.h
> index 5a34bdc..51f2800 100644
> --- a/client/canvas.h
> +++ b/client/canvas.h
> @@ -343,9 +343,6 @@ private:
>       ZlibDecoder _zlib_decoder;
>
>       SurfacesCache&  _surfaces_cache;
> -
> -    unsigned long _base;
> -    unsigned long _max;
>   };
>
>
> diff --git a/client/red_gdi_canvas.h b/client/red_gdi_canvas.h
> index fa173c4..77adcf7 100644
> --- a/client/red_gdi_canvas.h
> +++ b/client/red_gdi_canvas.h
> @@ -48,8 +48,6 @@ private:
>       RedPixmapGdi *_helper_pixmap;
>       HDC _dc;
>       HBITMAP _prev_bitmap;
> -    unsigned long _base;
> -    unsigned long _max;
>   };
>
>   #endif
> diff --git a/client/red_sw_canvas.h b/client/red_sw_canvas.h
> index 4736649..eb577ac 100644
> --- a/client/red_sw_canvas.h
> +++ b/client/red_sw_canvas.h
> @@ -45,8 +45,6 @@ public:
>
>   private:
>       RedPixmap *_pixmap;
> -    unsigned long _base;
> -    unsigned long _max;
>   };
>
>   #endif


More information about the Spice-devel mailing list