[Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

[Marc-André Lureau]

Hi

On Tue, May 8, 2012 at 12:51 PM, Uri Lublin <uril at redhat.com> wrote:
>>> Perhaps the header doesn't need to be conditionally excluded from the
>>> list of files.
>
>
> It is only used for Windows.
> Is it simpler to always add it and only use it for Windows compilation ?

>>> Also if it's not in the public API, it shouldn't be in the
>>> libspice_client_glibinclude_HEADERS.
>
>
> What is the appropriate list for WIN_USB_HDRS  ?
>
>

Not sure, but I think

The header could go unconditionnaly in libspice_client_glib_2_0_la_SOURCES.

If the file.c and the ifdef / includes are set right, that will not
affect the build, if winusb is disabled. But it will make sure it is
dist'ed.



-- 
Marc-André Lureau