[Spice-devel] [usbredir PATCH 1/6] configure: Windows: ignore usbredirserver and usbredirtestclient subdirs

Christophe Fergeau cfergeau at redhat.com
Tue May 15 02:58:25 PDT 2012


On Mon, May 14, 2012 at 10:22:52PM +0300, Uri Lublin wrote:
> On 05/03/2012 06:48 PM, Christophe Fergeau wrote:
> >What's wrong with the test client on Windows? The socket code?
> >
> 
> 
> I spent some time trying to make usbredirtestclient to work on
> Windows, but not too much.
> Various things needs to be ported (some are as easy as adding an
> include, some not as easy):
> 1. Socket (need to include winsock2.h and ws2tcpip.h, and possibly
> add something to the link command)
> 2. sigaction -- replace with signal
> 3. #undef interface (apparently it is defined)
> 4. #define _POSIX for signal values
> 5. "The *AI_NUMERICSERV* flag is defined on Windows SDK for Windows
> Vista and later"
> 6. more

Can you add this kind of explanations to the log message? This will make it
clear why it was disabled in case this is no longer an issue years in the
future, and someone wonders why we disabled it back in the days.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120515/9aee8c9d/attachment.pgp>


More information about the Spice-devel mailing list