[Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

Hans de Goede hdegoede at redhat.com
Thu May 17 23:43:13 PDT 2012


Hi,

On 05/17/2012 11:42 PM, Marc-André Lureau wrote:
> The remote may want to use that same key sequence,
> so we better send it through, even if it matches
> the ungrab key combination.

I'm not sure about this, if the grab-sequence is
getting in the way, maybe we need a different
grab-sequence?

What about only letting it through when in client mouse
mode, ie when it does not do anything wrt the client's
behavior?

Regards,

Hans


> ---
>   gtk/spice-widget.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
> index e6c252d..fad9db5 100644
> --- a/gtk/spice-widget.c
> +++ b/gtk/spice-widget.c
> @@ -979,8 +979,6 @@ static gboolean key_event(GtkWidget *widget, GdkEventKey *key)
>               else
>                   try_mouse_grab(display);
>           }
> -
> -        return true;
>       }
>
>       if (!d->inputs)


More information about the Spice-devel mailing list