[Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

Hans de Goede hdegoede at redhat.com
Fri May 18 05:06:49 PDT 2012


Hi,

On 05/18/2012 01:21 PM, Marc-André Lureau wrote:
>
>
> ----- Mensaje original -----
>> Hi,
>>
>> On 05/17/2012 11:42 PM, Marc-André Lureau wrote:
>>> The remote may want to use that same key sequence,
>>> so we better send it through, even if it matches
>>> the ungrab key combination.
>>
>> I'm not sure about this, if the grab-sequence is
>> getting in the way, maybe we need a different
>> grab-sequence?
>
> It's already configurable.
>
> Well, the advantage of using modifiers key for
> grab-sequence is that the side of effect is limited.
> In general ctrl+alt alone won't do anything on its own
> (that's why I think it was a good candidate)
>
> However, it still is better to send those modifiers
> to the guest, even if they match the grab sequence.

Agreed, for modifiers, but what if the key binding
is changed to shift+F12 as rhev does? Then I'm not sure
sending the key events to the guest is desirable ...

Regards,

Hans


More information about the Spice-devel mailing list