[Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

[Hans de Goede]

Hi,

On 05/18/2012 02:15 PM, Marc-André Lureau wrote:
> Hi
>
>> Agreed, for modifiers, but what if the key binding
>> is changed to shift+F12 as rhev does? Then I'm not sure
>> sending the key events to the guest is desirable ...
>
> what if we make this configurable, and default to
> non-passthrough? that will be up to the application to
> change the behaviour depending on the key-sequence used.

I could live with that, note I could even live with your
original patch I'm just not *sure* it is a good idea.

 From the same book ("not sure it is a good idea"), I'm
not really sure we should add yet another configurable
setting... How about passing the key event through if
it is a modifier key, and not if it is a regular key?

Regards,

Hans