[Spice-devel] [spice-gtk Win32 v2 PATCH 0/5] usb-redir support for Windows (mingw32)

Uri Lublin uril at redhat.com
Sun May 20 09:34:07 PDT 2012


Hello,

This patchset enables usb-redir support in spice-gtk running on Windows.

Patches 1, 2 fixes compilation on mingw with usbredir enabled.
Patch 1  - No need to review, was was already reviewed and acked.
Patch 2  - On windows GUDEV is not required.

Patch 3 adds GUdev like implementation for windows:
  - listening for USB device plug/unplug evevnts.
  - notifying registerees of such events.
  - provide similar api for minimal changes in usb-device-manager.

Patch 4 adds the capability to install a libusb driver dynamically
  - Assuming usbclerk is installed on the client machine.
  - Note that current implementation requires a rescan of USB devices
    (and an additional patch to libusbx).

Patch 5  Leak memory and prevent crashes.
    A ToDo list.


Changes in v2:
   - many review comments fixed
   - no --enable-gudev added to configure.ac. Instead GUDEV is checked
     on non-windows as a part of USBREDIR
   - a separate window is used for event listening (no gtk dependency)
   - snprintf patch of v1 is squashed in v2 patchset.
   - Windows USB source files appear in the tarballs of make dist.
   - spicy code is not changed (a result of using a separate window for events)

Arnon Gilboa (1):
  Windows mingw: usb: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

Uri Lublin (4):
  Move "err" variable definition to beginning of the function
  Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR
  Windows mingw: usb: Dynamically install a libusb driver for USB devices
  Windows mingw: usb: Comment out some memory cleanups not working on Windows

 configure.ac                 |   20 +++-
 gtk/Makefile.am              |   19 +++
 gtk/channel-usbredir.c       |    4 +-
 gtk/usb-device-manager.c     |   55 +++++++-
 gtk/usbclerk.h               |   35 ++++
 gtk/usbutil.c                |    1 +
 gtk/win-usb-dev.c            |  359 ++++++++++++++++++++++++++++++++++++++++++
 gtk/win-usb-dev.h            |   92 +++++++++++
 gtk/win-usb-driver-install.c |  213 +++++++++++++++++++++++++
 gtk/win-usb-driver-install.h |   39 +++++
 10 files changed, 834 insertions(+), 3 deletions(-)
 create mode 100644 gtk/usbclerk.h
 create mode 100644 gtk/win-usb-dev.c
 create mode 100644 gtk/win-usb-dev.h
 create mode 100644 gtk/win-usb-driver-install.c
 create mode 100644 gtk/win-usb-driver-install.h

-- 
1.7.7.6



More information about the Spice-devel mailing list