[Spice-devel] [usbredir v2 PATCH] support building usbredir for Windows with mingw

[Hans de Goede]

Hi,

On 05/28/2012 10:29 AM, Uri Lublin wrote:
> On 05/24/2012 05:59 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 05/24/2012 04:40 PM, Uri Lublin wrote:
>>> Out of v1 patch-set, all patches but one (patch 6) got acked.
>>>
>>> This patch-set contains a single patch, which is another solution
>>> for strtok_r missing in mingw. It's a simple implementation of
>>> strtok_r.
>>>
>>> Also I added a test program.
>>>
>>> Possibly I'm just missing a link-param to make strtok_s work with mingw64.
>>> If anyone knows it, I can try just replacing strtok_r with strtok_s for mingw.
>>>
>>> If a separate file/different name for win_strtok_t is preferred, let me know.
>>> If another implementation of strtok_r is preferred, let me know.
>>
>> I thought that the mingw in Fedora-17 does have a strtok_s, if that is correct
>> I would prefer to just use that.
>>
>> Any specific reason why you're rolling your own?
>
> With Fedora-17 mingw (mingw64) it compiles for me, but fails to run, due to a missing library:
> "msvcr100.dll was not found" or
> "The procedure entry point strtok_s could not be located is not defined").
> I tried with/without the following libraries which failed for me: msvcr100, msvcr90.
> I only found libmsvcr100.a and libmsvcr90.a, and could not found the matching .dll files.

Ok.

> Maybe I need to install something like Microsoft visual studio redistributable package.
> on the Windows client..

Maybe, but even if that would fix things it seems like more trouble then its worth. Given
this I'm ok with rolling our own.

So let me go and review that patch of you now...

Regards,

Hans