[Spice-devel] [PATCH] libwdi driver installer: use specific static libs

[Uri Lublin]

On 11/01/2012 12:24 PM, Arnon Gilboa wrote:
> -add Advapi32.lib ole32.lib, set RTL to MT instead of MD
> -otherwise it requires to install MS VC++ 2008 SP1 redist
> -solves libwdi error WDI_ERROR_NEEDS_ADMIN (-15)
> "Unable to run process with required administrative privileges"
>
> rhbz#857119


Patch itself looks good (generated from the options specified above).

But, I am not sure we should build it statically.
The good thing with static-libraries:
     No need for a separate install of the shared libraries.
The good thing with dynamic-libraries:
     If a security problem is found and fixed, no need to recompile.
     Other reasons exists (memory, size, load time).

Regards,
     Uri.